Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vis Builder] Removed Hard Coded Strings and Used i18n to translate #2867

Merged
merged 1 commit into from
Nov 14, 2022
Merged

[Vis Builder] Removed Hard Coded Strings and Used i18n to translate #2867

merged 1 commit into from
Nov 14, 2022

Conversation

AbhishekReddy1127
Copy link
Contributor

@AbhishekReddy1127 AbhishekReddy1127 commented Nov 11, 2022 •
edited
Loading

Signed-off-by: AbhishekReddy1127 [email protected]

Description

Removed Hard Coded Strings and Used i18n to translate. As of now we cannot implement the Localization methods we had here due to the variables.

Issues Resolved

Partially resolves #958

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AbhishekReddy1127 AbhishekReddy1127 changed the title [Vis Builder] Removed Hard Coded Strings and Used i18n to transalte [Vis Builder] Removed Hard Coded Strings and Used i18n to translate Nov 11, 2022
@AbhishekReddy1127 AbhishekReddy1127 marked this pull request as ready for review November 11, 2022 23:25
@AbhishekReddy1127 AbhishekReddy1127 requested a review from a team as a code owner November 11, 2022 23:25
ashwin-pc
ashwin-pc approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022 •
edited
Loading

Codecov Report

Merging #2867 (e6e52d7) into main (28c3df3) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2867      +/-   ##
==========================================
- Coverage   66.67%   66.67%   -0.01%     
==========================================
  Files        3219     3219              
  Lines       61445    61445              
  Branches     9417     9417              
==========================================
- Hits        40970    40968       -2     
- Misses      18229    18231       +2     
  Partials     2246     2246
Impacted Files Coverage Δ
...public/application/components/data_tab/dropbox.tsx 7.69% <ø> (ø)
...uilder/public/application/components/workspace.tsx 4.00% <ø> (ø)
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 50.00% <0.00%> (-2.64%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavilla kavilla added v2.5.0 'Issues and PRs related to version v2.5.0' backport 2.x labels Nov 14, 2022
@ashwin-pc ashwin-pc merged commit b19c171 into opensearch-project:main Nov 14, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2867-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b19c1717a29fffa1b40f8073c6dfb3fb4fe85972
# Push it to GitHub
git push --set-upstream origin backport/backport-2867-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2867-to-2.x.

lezzago pushed a commit to lezzago/OpenSearch-Dashboards that referenced this pull request Dec 12, 2022
@AbhishekReddy1127 @lezzago
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (o…
dafa74e 
…pensearch-project#2867)

Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
@AbhishekReddy1127 @AlexRuiz7
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (o…
2864656 
…pensearch-project#2867)

Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
@AbhishekReddy1127 @AlexRuiz7
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (o…
9266a41 
…pensearch-project#2867)

Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@AbhishekReddy1127 @sipopo
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (o…
da7b742 
…pensearch-project#2867)

Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: Sergey Osipov <[email protected]>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 6, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 6, 2023
@github-actions
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (#…
428f4d2 
…2867)

Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
(cherry picked from commit b19c171)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs pushed a commit that referenced this pull request Jan 6, 2023
@github-actions @manasvinibs
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (#…
1d9d70d 
…2867)

Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
(cherry picked from commit b19c171)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000 pushed a commit that referenced this pull request Jan 6, 2023
@opensearch-trigger-bot @github-actions
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (#…
ba932e0 
…2867) (#3189)

Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
(cherry picked from commit b19c171)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Arpit-Bandejiya pushed a commit to Arpit-Bandejiya/OpenSearch-Dashboards that referenced this pull request Jan 13, 2023
@AbhishekReddy1127 @Arpit-Bandejiya
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (o…
77458e5 
…pensearch-project#2867)

Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: Arpit Bandejiya <[email protected]>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@AbhishekReddy1127 @sikhote
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (o…
3136a60 
…pensearch-project#2867)

Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@AbhishekReddy1127 @sikhote
[Vis Builder] Removed Hard Coded Strings and Used i18n to transalte (o…
a95cdaf 
…pensearch-project#2867)

Signed-off-by: AbhishekReddy1127 <[email protected]>

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@kavilla kavilla kavilla approved these changes

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

Assignees
No one assigned
Labels
backport 2.x v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Vis Builder] Add Localization
6 participants
@AbhishekReddy1127 @codecov-commenter @kavilla @ashwin-pc @joshuarrrr @manasvinibs